Rework of x-os module / core profile #115

Merged
b12f merged 2 commits from feature/integrate-core-profile-into-x-os-and-rename-x-os-to-core into main 2 months ago
Owner
  • move core settings to x-os
  • add option to only install a lite core
  • rename x-os module to core
  • remove core profile from flake.nix
* move core settings to x-os * add option to only install a lite core * rename x-os module to core * remove core profile from flake.nix
hensoko added 1 commit 2 months ago
4190818304 Rework of x-os module / core profile
hensoko requested review from b12f 2 months ago
hensoko requested review from teutat3s 2 months ago
b12f requested changes 2 months ago
];
options.pub-solar.core = {
lite-core-active = mkOption {
Owner

I would just call this lite:

config.pub-solar.core.lite = true;
I would just call this `lite`: ``` config.pub-solar.core.lite = true; ```
lite-core-active = mkOption {
description = ''
Whether the node should run as a server or agent.
Note that the server, by default, also runs as an agent.
Owner

This description makes no sense

This description makes no sense
hensoko marked this conversation as resolved
pub-solar.terminal-life.enable = lib.mkIf (!cfg.lite-core-active) true;
pub-solar.audio.enable = lib.mkIf (!cfg.lite-core-active) true;
pub-solar.crypto.enable = lib.mkIf (!cfg.lite-core-active) true;
pub-solar.devops.enable = lib.mkIf (!cfg.lite-core-active) true;
Owner

I'd put all of these in core/default.nix directly under the option definition

I'd put all of these in `core/default.nix` directly under the option definition
# Modern modern utilities
p7zip
croc
jq
Owner

I'd argue this is core in 2022

I'd argue this is `core` in 2022
hensoko marked this conversation as resolved
pub-solar.graphical.wayland.software-renderer.enable = true;
pub-solar.sway.terminal = "foot";
pub-solar.x-os.iso-options.enable = true;
pub-solar.core.iso-options.enable = true;
Owner

Let's also enable the lite core option for the iso

Let's also enable the `lite` core option for the iso
Owner

Let's also enable the lite core option for the iso

Let's also enable the `lite` core option for the iso
hensoko added 1 commit 2 months ago
7785744d73 Move some packages from full to default set, move options for modules to
b12f approved these changes 2 months ago
b12f left a comment
Owner

LGTM

LGTM
b12f merged commit e436443bd2 into main 2 months ago
b12f deleted branch feature/integrate-core-profile-into-x-os-and-rename-x-os-to-core 2 months ago

Reviewers

teutat3s was requested for review 2 months ago
b12f approved these changes 2 months ago
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is failing
The pull request has been merged as e436443bd2.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/os#115
Loading…
There is no content yet.